Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-write using Volar: initially only supporting .gts #726

Merged
merged 93 commits into from
Jun 20, 2024

Conversation

machty
Copy link
Contributor

@machty machty commented Jun 20, 2024

This PR rebuilds Glint atop Volar.js, a language tooling framework used by Vue and many others.

The focus for this PR is to get Volar working with initial support only for .gts/.gjs files, i.e. a modern Polaris-edition Ember.js app. Support for classic two-file components will be investigated at a later date (but I am optimistic we can support that too).

Gameplan / TODO

  • Basic implementation for .gts VirtualCodes such that type-checking works in a .gts file with near feature parity for glint-main
  • reinstate augmentation for things like "Expected 2 arguments, but got 3. Note that named args are passed together as a final argument, so they collectively increase the given arg count by 1."
  • basic glint as tsc support
  • clean up and squash PR
  • re-enable CI lints
  • Passing tests for .gts files
  • Figure out how to resolve conflicts/overlapping with vsc-ember-syntax Transfer to ember-tooling lifeart/vsc-ember-syntax#72
    • I need to review how/why I inlined portions of that addon into this branch; I believe it's because otherwise Glint/Volar can't determine a language ID for .gts files

Likely save for future PR

machty and others added 30 commits May 31, 2024 11:45
get empty server running

basic TS feature parity

cleanup

tmp

notes

notes and fidgets

get something running on volar 2

too complicated

apha 14

2.0

get something compiling again

wip

use mdx as example. not vue

it builds

volar 2.0.1

get .gts autocomplete working

get something sorta showing up in Volar Labs

fix: use consistent lsp packages

absorb portions of vsc-ember-syntax

bump volar

get transormed IR showing up in labs

valid leaf tokens mapping to each other

fix comment

decode

avoid fileId hacks

cleanup

add gjs support

cleanup

volar 2.0.4

getting solo .hbs type-checking working

comments

bump

disable linting
@NullVoxPopuli
Copy link
Contributor

I'm merging this with red status, with the understanding that we're not going to release a stable v2 until the tests are green, and some more features are implemented (I've talked with @machty about this, and the goal here is to just get folks trying out Volar for some early feedback).

Next, I'm going to set up unstable releases like we have on embroider.
Standby.

@NullVoxPopuli NullVoxPopuli merged commit fc6f075 into typed-ember:main Jun 20, 2024
2 of 6 checks passed
@machty machty deleted the volar-3 branch June 20, 2024 15:16
@NullVoxPopuli NullVoxPopuli added enhancement New feature or request breaking A breaking change labels Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking A breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants